Skip to content

DistributedUpdateProcessor: expose isLeader, setupRequest #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsmiley wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

DistributedUpdateProcessor: expose isLeader, setupRequest #4878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ protected Replica.Type computeReplicaType() {
return Replica.Type.NRT;
}

boolean isLeader() {
public boolean isLeader() {
return isLeader;
}

Expand Down Expand Up @@ -995,9 +995,12 @@ private void doLocalDeleteByQuery(
}
}

// internal helper method to setup request by processors who use this class.
// NOTE: not called by this class!

@dsmiley dsmiley Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false; it is being called in several places.

void setupRequest(UpdateCommand cmd) {
/**
* Set up / initialize. Exposed for other processors to determine {@link #isLeader()} afterward.
*
* @lucene.internal
*/
public void setupRequest(UpdateCommand cmd) {
isLeader = getNonZkLeaderAssumption(req);
}

Expand Down
2 changes: 1 addition & 1 deletion solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ private String getLeaderUrlZk(String id) {
}

@Override
void setupRequest(UpdateCommand cmd) {
public void setupRequest(UpdateCommand cmd) {
zkCheck(cmd);
if (cmd instanceof AddUpdateCommand acmd) {
nodes = setupRequest(acmd.getIndexedIdStr(), acmd.getSolrInputDocument(), null, cmd);
Expand Down
Loading