SOLR-18153: Fix File Upload in Documents Tab of Admin UI#4204
Merged
epugh merged 2 commits intoapache:mainfrom Mar 12, 2026
Merged
SOLR-18153: Fix File Upload in Documents Tab of Admin UI#4204epugh merged 2 commits intoapache:mainfrom
epugh merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
This is a pretty small change, so I'm looking to merge it Thursday or Friday at the latest... |
epugh
added a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18153
Description
uploading a file works, but due to how success/error is handled, you get a brower console error and therefore no visual feedback.
Solution
The
.success()and.error()methods on the$httppromise were deprecated in AngularJS 1.4 and removed in AngularJS 1.6+. Since the documents are still actually indexed (the POST itself succeeds), the underlying$http.post()works fine — it's only the callback wiring that was broken.Tests
Tested both positive and negative cases manually and I see the appropriate feedback.
I also had claude check for OTHER situations like this, and this was the only one.