Enforce code formatting with ruff format (#45)#46
Conversation
- Add `make format` target (runs `ruff format .`) as the canonical way to auto-format sources before committing - Enable `ruff format --check .` in the `make lint` target - Document the format/lint workflow in DEVELOPER_GUIDE.md and AGENTS.md
Purely mechanical reformatting via `make format` (ruff format .). No logic changes — whitespace, quotes, and line wrapping only.
|
Dunno... Do we use ruff format for other python code across Solr project? Does all of this reformatting ever prevent us from updating solr-orbit with innovations form any of it's upstream projects? Though we have renamed so much.. and AI tooling of course may make that less important.... |
Well, this is our largest python codebase, so I think it matters more than for the utility scripts we have in main repo. We could surely maintain this tool with just loosely documented conventions, but I think we have good experience with code formatting both for java and go (operator). If we do this, we should add a |
First commit in this PR branch
ruff format --check .in themake linttarget (was commented out)make formattarget as the canonical way to auto-format sourcesmake format/make lintworkflow in DEVELOPER_GUIDE.md and AGENTS.mdSecond commit
ruff format .- reformats all source files