Replace pylint with ruff#44
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the project’s Python linting toolchain from pylint to ruff, updates developer/CI entry points to use ruff check, and includes a handful of small code cleanups to satisfy the new lint rules/config.
Changes:
- Remove
pylintconfiguration and dependency; addruffconfiguration under[tool.ruff]inpyproject.toml. - Update
make lint(and developer docs) to runruff check .. - Apply small lint-driven fixes across the codebase (import splitting,
not instyle, remove unused import/exception binding, whitespace cleanup).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/unit/solr/test_client.py |
Split multi-import statements to satisfy linting style. |
solrorbit/workload/params.py |
Use idiomatic not in membership checks. |
solrorbit/workload/loader.py |
Use idiomatic not in membership checks. |
solrorbit/worker_coordinator/worker_coordinator.py |
Remove unused exception binding in a JSON parsing except. |
solrorbit/metrics.py |
Remove an unused stdlib import (time). |
scripts/expand-data-corpus.py |
Fix indentation/whitespace in an argparse help string literal block. |
pyproject.toml |
Replace pylint with ruff dependency and add ruff configuration. |
Makefile |
Switch lint target from pylint to ruff check .. |
AGENTS.md |
Update developer guidance to reference ruff instead of pylint. |
.pylintrc |
Remove pylint configuration file. |
.ci/scripts/check_deprecated_terms.py |
Split multi-import statement to satisfy linting style. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just replaces the tool and fixes some linting issues.
Closes #6
(In another PR we'll enforce source formatting with ruff as well.)