Move frontpage selection into the administrator setup workflow by snoopdave · Pull Request #170 · apache/roller

snoopdave · 2026-08-29T21:10:09Z

The setup page is reachable without a login so a freshly installed site can be
bootstrapped before any user exists. This change makes that page a read-only
bootstrap view and moves the frontpage-weblog selection into a separate
global-administrator action.

What changed

While the site has zero users, show only a minimal public bootstrap page —
no weblog lists, counts, or mutating action.
Make the initial frontpage selection a separate POST action requiring global
administrator permission, allowed only while no frontpage weblog has been set.
Route later changes through GlobalConfig.
Centralize canonical-handle resolution and enabled-weblog validation in one
service used by both write paths; reject blank, missing, nonexistent, and
disabled weblogs and treat a missing aggregation checkbox as false.
Persist both properties together and invalidate local site-wide page/feed
caches, including the site-wide last-modified value.
Fail closed when users.firstUserAdmin=false until a global administrator is
provisioned.

Tests

Anonymous zero-user page; anonymous and non-admin access after users exist;
disabled admin and global-admin callers.
Both first-user-admin settings; initial, concurrent, and already-configured
writes; the retired setup!save action no longer resolves.
Invalid weblog handles, null aggregation, successful reads, and local cache
invalidation through both write paths.

Setup is a read-only bootstrap page. Choosing the initial frontpage weblog is a separate global-administrator action reached by POST (FrontpageSetup); later changes go through global configuration, which resolves the handle through the shared FrontpageSettings service. The service stores the weblog's canonical handle, treats a missing aggregation checkbox as false, writes both properties before a single flush, and clears the site-wide, page and feed caches so the change is visible on this node. save() rejects non-POST requests. Peers pick the change up when their own cache entries expire; Roller has no cross-node invalidation transport and this does not add one. Claude-Session: https://claude.ai/code/session_01A1fhY1E2PCFU6UAPXu2WtV

mraible

Reviewed. The setup-flow changes are moving in the right direction. Please resolve the front-page and setup regressions noted in the review before merge.

mraible · 2026-08-31T03:06:07Z

-            WebloggerFactory.getWeblogger().flush();
+        // Beyond that point this is a site configuration screen.
+        if (!isUserIsAdmin()) {
+            return DENIED;


index.jsp (lines 29-31) forwards / here whenever the frontpage handle is blank, so returning DENIED for non-admins makes the home page an access-denied tile for every visitor of a site that has users but no frontpage yet (checkPermission with a null user throws and isUserIsAdmin() swallows it to false). The page only showed counts and links before; I'd keep execute() open and gate the form in the JSP on isUserIsAdmin(), leaving the POST admin-only.

mraible · 2026-08-31T03:06:07Z


-            addMessage("frontpageConfig.values.saved");
+        try {
+            if (FrontpageSettings.isConfigured()) {


JPAWeblogManagerImpl.removeWeblog doesn't clear site.frontpage.weblog.handle, so after the frontpage weblog is deleted isConfigured() is still true and this redirects to /, which forwards to the missing weblog. On master the admin could come back here and pick another one. Either treat a handle that doesn't resolve as unconfigured, or clear the property in removeWeblog.

mraible · 2026-08-31T03:06:07Z

+
+        } catch (FrontpageSettings.InvalidFrontpageWeblogException ex) {
+            addError("frontpageConfig.invalidWeblog");
+            return INPUT;


struts.xml maps input for this action to the .Setup tile, but Setup.jsp reads userCount, blogCount, weblogs and bootstrap, none of which exist on FrontpageSetup, so every <s:if> is false and the admin sees the error above three empty panels with no chooser. Either redirect back to setup carrying the message, or give this action the same properties.

mraible · 2026-08-31T03:06:07Z

@@ -93,7 +93,8 @@

        <s:if test="blogCount > 0">


The heading was changed to blogCount > 0 && !bootstrap but this guard wasn't, so in bootstrap mode (weblogs exist, zero users, weblogs is null) anonymous visitors still get the form with an empty select and a Save that POSTs to an admin-only action.

mraible · 2026-08-31T03:06:07Z

+            // losing caller is told the choice is already made.
+            if (FrontpageSettings.isConfigured()) {
+                addError("frontpageConfig.alreadyConfigured");
+                return "home";


rollerStack has no MessageStore interceptor, so this addError is discarded by the redirectAction; the second admin just lands on the winner's frontpage. The comment above says the loser is told, but they aren't.

mraible · 2026-08-31T03:06:07Z

+            return null;
+        }
+        return WebloggerFactory.getWeblogger().getWeblogManager()
+                .getWeblogByHandle(handle.trim(), Boolean.TRUE);


getWeblogByHandle throws WebloggerException("Invalid handle") for anything outside [A-Za-z0-9_], so a POST with frontpageBlog=my-blog takes the generic WebloggerException branch (stack trace at ERROR, "Error saving properties") instead of the invalid-weblog message this method documents. Pre-check the handle or catch that case here.

mraible · 2026-08-31T03:06:07Z

+                    if (FrontpageSettings.resolveWeblog(incomingProp) == null) {
+                        addError("frontpageConfig.invalidWeblog");
+                    } else {
+                        updProp.setValue( incomingProp.trim() );


This validates via resolveWeblog but then stores the raw value itself instead of calling FrontpageSettings.apply(), so changing the frontpage from Global Config skips the cache invalidation the class javadoc promises for "both screens" and keeps serving the old weblog's cached pages and feeds.

mraible · 2026-08-31T03:06:07Z

+import org.apache.roller.weblogger.WebloggerException;
+import org.apache.roller.weblogger.pojos.RuntimeConfigProperty;
+import org.apache.roller.weblogger.pojos.Weblog;
+import org.apache.roller.weblogger.ui.rendering.util.cache.SiteWideCache;


First business → ui.rendering dependency in the tree; SiteWideCache / WeblogPageCache / WeblogFeedCache are rendering singletons that bootstrap caches on getInstance(). The invalidation belongs in the actions (FrontpageSetup / GlobalConfig), with FrontpageSettings just resolving and storing.

mraible · 2026-08-31T03:06:07Z

+        int setupIdx = struts.indexOf("name=\"setup\"");
+        assertTrue(setupIdx > 0, "setup action not found in struts.xml");
+        String setupBlock = struts.substring(setupIdx, struts.indexOf("</action>", setupIdx));
+        assertFalse(setupBlock.contains("save"),


These assert on source text (contains("save"), method=\"post\"), so an XML comment containing save in the setup block fails the build while a reachable-but-unguarded action passes. requiredGlobalPermissionActions is the only behavioural check here; I'd drop the text ones.

snoopdave added the 6.1.6 label Aug 29, 2026

mraible reviewed Aug 31, 2026

View reviewed changes

apache deleted a comment from mraible Sep 1, 2026

Navigation Menu

Uh oh!

Move frontpage selection into the administrator setup workflow - #170

Move frontpage selection into the administrator setup workflow#170
snoopdave wants to merge 1 commit into
masterfrom
frontpage-setup-workflow

snoopdave commented Aug 29, 2026

Uh oh!

mraible left a comment •

edited by snoopdave

Loading

Uh oh!

mraible Aug 31, 2026 •

edited

Loading

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026 •

edited

Loading

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026

Uh oh!

mraible Aug 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

snoopdave commented Aug 29, 2026

What changed

Tests

Uh oh!

mraible left a comment • edited by snoopdave Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

mraible Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mraible left a comment •

edited by snoopdave

Loading

mraible Aug 31, 2026 •

edited

Loading

mraible Aug 31, 2026 •

edited

Loading