Skip to content

[ISSUE #11176] Fix incorrect filter appender name in broker logging configuration - #11177

Open
majialoong wants to merge 1 commit into
apache:developfrom
majialoong:ISSUE-11176
Open

majialoong wants to merge 1 commit into
apache:developfrom
majialoong:ISSUE-11176

Conversation

@majialoong

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Brief Description

Fix the incorrect filter appender name.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.40%. Comparing base (42a6d57) to head (77d4a6e).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11177      +/-   ##
=============================================
- Coverage      49.46%   49.40%   -0.06%     
+ Complexity     14276    14264      -12     
=============================================
  Files           1390     1390              
  Lines         103148   103148              
  Branches       13483    13483              
=============================================
- Hits           51017    50961      -56     
- Misses         45968    46015      +47     
- Partials        6163     6172       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR fixes a copy-paste naming error in the broker logback configuration: the outer AsyncAppender wrapper for the filter sifting appender was incorrectly named RocketmqRebalanceLockSiftingAppender instead of RocketmqFilterSiftingAppender. The inner appender-ref already correctly references RocketmqFilterSiftingAppender_inner, so this rename makes the outer name consistent.

LGTM — trivial, correct, and all CI checks pass.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect filter appender name in broker logging configuration

3 participants