[ISSUE #11176] Fix incorrect filter appender name in broker logging configuration - #11177
Open
majialoong wants to merge 1 commit into
Open
majialoong wants to merge 1 commit into
majialoong wants to merge 1 commit into
Conversation
…ging configuration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11177 +/- ##
=============================================
- Coverage 49.46% 49.40% -0.06%
+ Complexity 14276 14264 -12
=============================================
Files 1390 1390
Lines 103148 103148
Branches 13483 13483
=============================================
- Hits 51017 50961 -56
- Misses 45968 46015 +47
- Partials 6163 6172 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Sep 17, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
This PR fixes a copy-paste naming error in the broker logback configuration: the outer AsyncAppender wrapper for the filter sifting appender was incorrectly named RocketmqRebalanceLockSiftingAppender instead of RocketmqFilterSiftingAppender. The inner appender-ref already correctly references RocketmqFilterSiftingAppender_inner, so this rename makes the outer name consistent.
LGTM — trivial, correct, and all CI checks pass.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Fix the incorrect filter appender name.