Conversation
…ved compile configuration
RockteMQ-AI
approved these changes
Sep 14, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
LGTM — straightforward and correct fix for outdated Gradle dependency syntax.
Review Notes
- Correctness: ✅ → is the right migration path per Gradle 7.0 release notes
- Completeness: ✅ All 3 occurrences updated (2 Chinese docs, 1 English doc)
- Testing: ✅ Author verified with Gradle 9.7.1 and confirmed the dependency resolves correctly
- Scope: ✅ Minimal change, no unintended side effects
The PR description is thorough and explains the rationale well. This fixes a real pain point for users following the quick-start guide with modern Gradle versions.
Thanks for the contribution!
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
The Gradle snippets in the quick-start docs still use
compile, which Gradle removed in 7.0. Copying them into a current build fails while the project is being evaluated, and the error reads like a method-name typo with no hint that the configuration itself is gone. Switched toimplementation, which is what the Gradle upgrade guide's migration table mapscompileto. The other option in that table,api, requires thejava-libraryplugin, and these snippets are for sample applications.The Maven blocks right above them are untouched.
How Did You Test This Change?
Docs only, no code path affected. Checked on Gradle 9.7.1 with a minimal
javaproject: withcompilethe build fails with "Could not find method compile() for arguments [...] on object of type ...DefaultDependencyHandler", withimplementationit succeeds and resolves rocketmq-client:5.5.0 along with its transitive dependencies from Maven Central, which also confirms the coordinates and version already in the docs are correct.Grepped the whole tree on develop too. These are the only Gradle-style dependency declarations and the only files that mention Gradle at all, so nothing is left half-migrated.