Conversation
…on list offlineClientLiteSubscription only took subscriptions(0) to build the COMPLETE_REMOVE LiteSubscriptionDTO, so a lite consumer subscribing to multiple topics left stale subscriptions on the broker for every topic after the first one. When the subscription list was empty, getSubscriptions(0) threw IndexOutOfBoundsException which was swallowed by the catch block, so the cleanup was silently skipped entirely and the stale lite subscription could trigger LITE_SUBSCRIPTION_QUOTA_EXCEEDED on the next connect. Iterate over all subscription entries and send one COMPLETE_REMOVE per topic; an empty list now simply sends nothing.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fix offlineClientLiteSubscription to iterate over all subscription entries instead of only processing the first one. Also guards against empty subscription lists.
LGTM — correct fix for multi-topic lite subscription cleanup.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GrpcClientSettingsManager.offlineClientLiteSubscriptiononly tooksubscriptions(0)to build theCOMPLETE_REMOVELiteSubscriptionDTO:getSubscriptions(0)threwIndexOutOfBoundsException, which the surrounding catch block swallowed — so the cleanup was silently skipped entirely, and the stale lite subscription could triggerLITE_SUBSCRIPTION_QUOTA_EXCEEDEDon the next connect.Modifications
Iterate over all subscription entries and send one
COMPLETE_REMOVEper topic; an empty list now simply sends nothing.Verification
Fail-before (new tests, run against the unpatched code):
Pass-after: