Conversation
The telemetry stream observer keeps proxyCtx = null until the first onNext delivers a context. A client that opens the telemetry stream and then cancels (or drops the connection) without sending a single TelemetryCommand made onError call handleGrpcCancel with a null context, which threw a NullPointerException in ctx.getClientID() and masked the intended cancel handling. Return early when the context is absent; there is no client id to clean up in that case.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Adds a null check for ctx in handleGrpcCancel to prevent NPE when the gRPC context is already cleared. Test verifies no exception is thrown.
LGTM — simple defensive null guard.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The telemetry stream observer keeps
proxyCtx = nulluntil the firstonNextdelivers a context. A client that opens the telemetry stream and then cancels (or drops the connection) without sending a singleTelemetryCommandmadeonErrorcallhandleGrpcCancelwith a null context, which threw aNullPointerExceptioninctx.getClientID()and masked the intended cancel handling.Modifications
Return early when the context is absent; there is no client id to clean up in that case.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: