Conversation
…ull in receiveMessage A gRPC client that calls ReceiveMessage before any settings were cached (or after its settings were cleaned up) made getClientSettings return null, and the following settings.getClientType() threw a NullPointerException which the catch block turned into an opaque INTERNAL_SERVER_ERROR response. ClientActivity.heartbeat already guards this case with UNRECOGNIZED_CLIENT_TYPE; apply the same guard in receiveMessage so the client gets a meaningful code.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Add null check for client settings in receiveMessage, returning UNRECOGNIZED_CLIENT_TYPE instead of NPE when settings are not found.
LGTM — proper error handling for missing client configuration.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A gRPC client that calls
ReceiveMessagebefore any settings were cached (or after its settings were cleaned up) madegetClientSettingsreturn null, and the followingsettings.getClientType()threw aNullPointerExceptionwhich the catch block turned into an opaqueINTERNAL_SERVER_ERRORresponse.ClientActivity.heartbeatalready guards this case withUNRECOGNIZED_CLIENT_TYPE.Modifications
Apply the same guard in
receiveMessageso the client gets a meaningful code.Verification
Fail-before (new test, run against the unpatched code):
Pass-after: