RANGER-5632: update plugins packaging to have audit-server as the only audit destination#999
Open
mneethiraj wants to merge 1 commit into
Open
RANGER-5632: update plugins packaging to have audit-server as the only audit destination#999mneethiraj wants to merge 1 commit into
mneethiraj wants to merge 1 commit into
Conversation
…y audit destination
mneethiraj
requested review from
Copilot,
kumaab,
pradeepagrawal8184 and
rameeshm
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Ranger plugin packaging so that plugin distributions include only the audit-server audit destination (removing legacy audit destination artifacts from plugin module dependencies and assembly includes).
Changes:
- Removed
ranger-audit-dest-hdfs/ranger-audit-dest-solrdependencies from multiple plugin/module POMs (keepingranger-audit-dest-auditserver). - Removed
ranger-audit-dest-hdfs/ranger-audit-dest-solr(and for Elasticsearch plugin,ranger-audit-dest-es) from distro assembly descriptors for plugins/agents. - Added
ranger-audit-dest-auditserveras a provided dependency indistro/pom.xmland switchedauthz-embeddedto depend onranger-audit-dest-auditserver.
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ranger-examples/plugin-sampleapp/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-yarn/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-trino/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-sqoop/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-solr/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-presto/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-ozone/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-nifi/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-nifi-registry/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-kylin/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-kudu/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-kms/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-kafka/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-elasticsearch/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| plugin-atlas/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| knox-agent/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| hive-agent/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| hdfs-agent/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| hbase-agent/pom.xml | Drops HDFS/Solr audit destination deps; keeps audit-server destination. |
| distro/src/main/assembly/storm-agent.xml | Removes HDFS/Solr audit destination artifacts from the assembled agent package. |
| distro/src/main/assembly/plugin-yarn.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-trino.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-sqoop.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-solr.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-presto.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-ozone.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-kylin.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-kms.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-kafka.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/plugin-elasticsearch.xml | Removes ES/HDFS audit destination artifacts from the assembled plugin package (leaving audit-server). |
| distro/src/main/assembly/plugin-atlas.xml | Removes HDFS/Solr audit destination artifacts from the assembled plugin package. |
| distro/src/main/assembly/pdp.xml | Removes HDFS/Solr audit destination artifacts from the assembled PDP package. |
| distro/src/main/assembly/knox-agent.xml | Removes HDFS/Solr audit destination artifacts from the assembled agent package. |
| distro/src/main/assembly/kms.xml | Removes HDFS/Solr audit destination artifacts from the assembled KMS distribution. |
| distro/src/main/assembly/hive-agent.xml | Removes HDFS/Solr audit destination artifacts from the assembled agent package. |
| distro/src/main/assembly/hdfs-agent.xml | Removes HDFS/Solr audit destination artifacts from the assembled agent package. |
| distro/src/main/assembly/hbase-agent.xml | Removes HDFS/Solr audit destination artifacts from the assembled agent package. |
| distro/pom.xml | Adds provided dependency on ranger-audit-dest-auditserver. |
| authz-embedded/pom.xml | Replaces HDFS/Solr audit destination deps with ranger-audit-dest-auditserver. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+85
| <dependency> | ||
| <groupId>org.apache.ranger</groupId> | ||
| <artifactId>ranger-audit-dest-auditserver</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
updated plugins packaging to remove all audit destinations other than audit-server destination.
How was this patch tested?
Verified the following using docker setup: