[fix][test] Fix flaky OneWayReplicatorUsingGlobalZKTest cleanup#25313
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky OneWayReplicatorUsingGlobalZKTest cleanup#25313merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
When using global ZK, reducing replication clusters triggers async topic cleanup on removed clusters. The namespace force-delete can fail with HTTP 422 if topics are still in a transitional state. Retry namespace deletion with Awaitility to handle this race.
github-actions
bot
added
doc-not-needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25313 +/- ##
============================================
+ Coverage 72.54% 72.65% +0.10%
- Complexity 34627 34647 +20
============================================
Files 1967 1967
Lines 156326 156326
Branches 17812 17812
============================================
+ Hits 113409 113571 +162
+ Misses 33814 33675 -139
+ Partials 9103 9080 -23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OneWayReplicatorUsingGlobalZKTest.cleanupthat fails with HTTP 422deleteNamespacecalls withAwaitilityretry to handle this race condition.Test plan
OneWayReplicatorUsingGlobalZKTestno longer fails during cleanupdocdoc-requireddoc-not-neededdoc-complete