[feat][monitor] Add custom topic metric labels to OpenTelemetry metrics attributes#25306
Open
coderzc wants to merge 2 commits intoapache:masterfrom
Open
[feat][monitor] Add custom topic metric labels to OpenTelemetry metrics attributes#25306coderzc wants to merge 2 commits intoapache:masterfrom
coderzc wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: N/A
PIP: https://github.com/apache/pulsar/blob/master/pip/pip-447.md
Motivation
This PR is part 2 of PIP-447.
Part 1 for Prometheus labels has already been merged in #24991. This follow-up extends the same custom topic metric label support to OpenTelemetry topic metrics so both metrics pipelines expose the same topic property based labels.
Modifications
PersistentTopicAttributesto build OpenTelemetry attributes with custom labelsOpenTelemetryTopicStatsto attach custom labels across topic metricsmasterVerifying this change
This change added tests and can be verified as follows:
mvn clean install -DskipTestsOpenTelemetryCustomLabelsTestto verify custom labels are exposed in OpenTelemetry metrics and omitted when the feature is disabledDoes this pull request potentially affect one of the following parts:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#51