chore(deps): bump pygments from 2.19.2 to 2.20.0 in /client/python#4084
chore(deps): bump pygments from 2.19.2 to 2.20.0 in /client/python#4084dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
The license check failed, which is weird as we just bump up the version. |
|
@flyrain I hope the license didn't change on a minor version bump 😄 |
That's what I thought as well. |
|
So the older version has following: And the newer version has following: We are using following to check what are allowed: Looking at this https://github.com/pygments/pygments, it had been BSD-2-Clause for years. The reason on why this happened is due to non PEP 639 compatible metadata which got fixed in pygments/pygments@4a73776 (and this is in 2.20.0 release). Then looking at dependency tree, this is added by |
|
Per this page, https://www.apache.org/legal/resolved.html#category-a, BSD-2-Clause is allowed in an ASF Project? We will need to update our checker. |
Yes, I was looking at it as well. Let me quickly fix it. |
|
Here is the PR, #4100 |
|
BTW, we can't merge this one. I was looking into this one for pyiceberg last night: apache/iceberg-python#3209 |
|
Let us put a change request then. |
flyrain
left a comment
There was a problem hiding this comment.
@MonkeyCanCode is investigating pygments/pygments#3076
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps [pygments](https://github.com/pygments/pygments) from 2.19.2 to 2.20.0. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.19.2...2.20.0) --- updated-dependencies: - dependency-name: pygments dependency-version: 2.20.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
1f0454f to
90876ac
Compare
Bumps pygments from 2.19.2 to 2.20.0.
Release notes
Sourced from pygments's releases.
Changelog
Sourced from pygments's changelog.
Commits
708197dFix underline length.1d4538aPrepare 2.20 release.2ceaee4Update CHANGES.e3a3c54Fix Haskell lexer: handle escape sequences in character literals (#3069)d7c3453Merge pull request #3071 from pygments/harden-html-formatter0f97e7cHarden the HTML formatter against CSS.9f981b2Update CHANGES.1d88915Update CHANGES.c3d93adFix ASN.1 lexer: recognize minus sign and fix range operator (#3060)4f06bcffix bad behaving backtracking regex in CommonLispLexer