[controller] Sanitize table configuration representations - #19236
Draft
xiangfu0 wants to merge 1 commit into
Draft
[controller] Sanitize table configuration representations#19236xiangfu0 wants to merge 1 commit into
xiangfu0 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19236 +/- ##
============================================
- Coverage 66.97% 57.79% -9.19%
+ Complexity 1417 7 -1410
============================================
Files 3453 2660 -793
Lines 218858 160237 -58621
Branches 34787 26463 -8324
============================================
- Hits 146591 92605 -53986
+ Misses 60556 59675 -881
+ Partials 11711 7957 -3754
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
xiangfu0/table-config-redaction
branch
from
August 13, 2026 09:04
9d9d140 to
ca39cb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_znodepermission for raw ZooKeeper reads and avoid including configuration values in related diagnostics.Root cause
Table configuration representations were produced through several independent paths without a shared masking and update policy. Some paths also used getters that apply variable replacement before rendering, while update handling had no safe interpretation for values returned as masks.
Update semantics
*****retains the corresponding unresolved stored value only when the property and consumer identity are unchanged and unambiguous.How to reproduce
*****, the placeholder and benign property are unchanged, and raw ZooKeeper retrieval is denied withoutget_znode.Validation
28/28and controller/API/SHOW/MV85/85.spotless:apply,license:format,checkstyle:check, andlicense:checkpassed for all affected modules.test-compilepassed on JDK 25 with-Xlint:alland no warnings on added lines.git diff --checkpassed.The full reactor
test-compile -amgate remains blocked in unchangedpinot-segment-localby a pre-existing zstd-jni annotation classpath issue. Direct compilation of every modified module passes.