Validate segment upload destinations - #19231
Draft
xiangfu0 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19231 +/- ##
==============================================
+ Coverage 66.97% 100.00% +33.02%
+ Complexity 1417 6 -1411
==============================================
Files 3453 3 -3450
Lines 218858 6 -218852
Branches 34787 0 -34787
==============================================
- Hits 146591 6 -146585
+ Misses 60556 0 -60556
+ Partials 11711 0 -11711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
xiangfu0/bind-segment-upload-destination
branch
from
August 13, 2026 09:04
0602c61 to
6965a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The upload handlers did not share a canonical destination-binding step across request inputs and segment metadata. In v1, authorization could therefore complete before the final table destination was established.
Impact
Upload and refresh authorization now targets the same table used by all subsequent controller operations, independently of the configured access-control implementation. Existing valid v2 promotion behavior remains supported.
How to reproduce
Run the added
PinotSegmentUploadAuthorizationTest. It configures permissive cluster-level create access with table-scoped authorization and exercises v1, v2, batch, upload, and refresh destination handling.Validation
FineGrainedAuthUtilsTestPinotSegmentUploadDownloadRestletResourceTestPinotSegmentUploadAuthorizationTestpinot-coreandpinot-controller