Fix flaky ExactlyOnce and PartialUpsertRebalance integration tests#17834
Closed
xiangfu0 wants to merge 2 commits intoapache:masterfrom
Closed
Fix flaky ExactlyOnce and PartialUpsertRebalance integration tests#17834xiangfu0 wants to merge 2 commits intoapache:masterfrom
xiangfu0 wants to merge 2 commits intoapache:masterfrom
Conversation
- ExactlyOnce: Use single KafkaProducer for abort+commit transactions to ensure proper state machine sequencing of transaction markers, and verify committed records are visible before proceeding. - PartialUpsertRebalance: Replace pause/drop-segments/restart cleanup with drop/recreate table lifecycle; re-init SegmentBuildTimeLeaseExtender executor after stopping servers; add dropRealtimeTable in tearDown. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17834 +/- ##
============================================
- Coverage 63.34% 63.26% -0.08%
- Complexity 1456 1466 +10
============================================
Files 3189 3190 +1
Lines 191782 191904 +122
Branches 29358 29390 +32
============================================
- Hits 121480 121404 -76
- Misses 60801 61001 +200
+ Partials 9501 9499 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KafkaProducerfor both abort and commit transactions to ensure proper state machine sequencing of transaction markers. Added verification that committed records are visible toread_committedconsumers before proceeding.SegmentBuildTimeLeaseExtenderexecutor after stopping servers. AdddropRealtimeTableintearDown.Test plan
ExactlyOnceKafkaRealtimeClusterIntegrationTestpasses locally (9 run, 0 failures)PartialUpsertTableRebalanceIntegrationTestpasses locally (3 run, 0 failures)🤖 Generated with Claude Code