Add batch planFetchForProcessing API to FetchPlanner#17816
Open
rhodo wants to merge 2 commits intoapache:masterfrom
Open
Add batch planFetchForProcessing API to FetchPlanner#17816rhodo wants to merge 2 commits intoapache:masterfrom
rhodo wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17816 +/- ##
============================================
+ Coverage 63.21% 63.23% +0.02%
- Complexity 1454 1456 +2
============================================
Files 3183 3188 +5
Lines 191428 191738 +310
Branches 29273 29348 +75
============================================
+ Hits 121003 121241 +238
- Misses 60984 61010 +26
- Partials 9441 9487 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-segment planFetchForProcessing(IndexSegment, QueryContext) with a batch planFetchForProcessing(List, QueryContext) on the FetchPlanner interface. This allows implementations to precompute query-derived information once instead of redundantly per segment.