PHOENIX-7786 Improved handling for empty files in Replication Log Processor#2392
Open
Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Open
PHOENIX-7786 Improved handling for empty files in Replication Log Processor#2392Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Conversation
tkhurana
reviewed
Mar 18, 2026
| // If trailer is missing or corrupt, create reader without trailer validation | ||
| LOG.warn("Invalid Trailer for file {}", filePath, invalidLogTrailerException); | ||
| logFileReaderContext.setValidateTrailer(false); | ||
| logFileReader.init(logFileReaderContext); |
Contributor
There was a problem hiding this comment.
There is still a leak here because the socket is created in the init call. https://github.com/apache/phoenix/blob/PHOENIX-7562-feature-new/phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/LogFileReader.java#L49
Contributor
There was a problem hiding this comment.
There are 2 init calls here so we need to handle failures from any of the two and close the reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.