Remove external sbt-dependency-graph plugin - #1307
Merged
pjfanning merged 1 commit intoSep 18, 2026
Merged
Conversation
Motivation: The legacy sbt-dependency-graph plugin is no longer needed because dependency-tree support is available in sbt itself. Modification: Use addDependencyTreePlugin and derive PR validation module IDs directly from public UpdateReport data instead of legacy plugin graph types. Result: The build uses sbt 1.13 dependency-tree support while preserving PR impact analysis without obsolete plugin APIs. Tests: - sbt -batch "show sbtVersion" (passed; meta-build compiled with sbt 1.13.0) - Test suites not run per request. References: Fixes apache#452
Contributor
Author
|
Green. |
Philippus
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbt-dependency-graph#452Motivation
sbt has included dependency-tree support since 1.4. Pekko HTTP uses sbt 1.13.0, so the legacy
net.virtual-voiddependency is no longer needed.The pull-request validator still relied on graph model classes supplied by that plugin.
Modification
sbt-dependency-graphwithaddDependencyTreePlugin.UpdateReportdata.Result
The build uses the dependency-tree implementation supplied for sbt 1.13.0 and no longer depends on the legacy plugin APIs.
Pull-request impact analysis retains the previous project-selection behavior.
Tests
sbt -batch "show sbtVersion"— passed; loaded the build and compiled 21 meta-build sources with sbt 1.13.0.git diff --check— passed.