Increase chunk-size cap in Filter.decode() for large streams - #528
Open
valerybokov wants to merge 1 commit into
Open
Increase chunk-size cap in Filter.decode() for large streams#528valerybokov wants to merge 1 commit into
valerybokov wants to merge 1 commit into
Conversation
Author
|
Another question. It looks like the issue https://issues.apache.org/jira/browse/PDFBOX-5491 is okay now. Some code fixed a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer chunk-size estimate in the static decode() collapsed to the
flat 4KB default for any encoded stream >= 1KB, forcing thousands of
separate 4KB chunk allocations in RandomAccessReadWriteBuffer when
decoding large images/fonts. Cap the estimate at 1MB instead of
falling back to 4KB, cutting the number of chunk allocations for large
streams while still bounding worst-case preallocation