PDFBOX-5284: Refactor Refactor PDFTabulaTextStripper to improve test … #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

wx930910 wants to merge 1 commit into apache:trunk from wx930910:PDFBOX-5284

wx930910 commented Sep 24, 2021

Jira

PDFBOX-5284

Description

Replace test class PDFTabulaTextStripper by spying object and improve test design

Motivation

Decouple test class PDFTabulaTextStripper from production class PDFTextStripper.
Remove the redundant test child class PDFTabulaTextStripper
Remove the redundant constructor.

Key changed/added classes in this PR

Created spying object to replace test subclass PDFTabulaTextStripper, decoupled test from production code.
Created method that return the mocking object for code reuse.


          PDFBOX-5284: Refactor Refactor PDFTabulaTextStripper to improve test …

2b9dc1c

…design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet