Skip to content

MINOR: Cover plaintext-footer CTR in encryption interoperability tests - #3925

Open
autoCAT6 wants to merge 1 commit into
apache:masterfrom
autoCAT6:test/ctr-plaintext-footer-interop
Open

autoCAT6 wants to merge 1 commit into
apache:masterfrom
autoCAT6:test/ctr-plaintext-footer-interop

Conversation

@autoCAT6

@autoCAT6 autoCAT6 commented Nov 1, 2026

Copy link
Copy Markdown

Rationale for this change

The encryption matrix omits AES_GCM_CTR_V1 with a plaintext footer. Cover this combination using Adam Reeve's shared C++ sample from apache/parquet-testing#130, alongside the Java writer's own round trip.

What changes are included in this PR?

  • Add the configuration to the existing writer/decryption and interoperability matrices, including projection of plaintext columns without decryption properties.
  • Pin the new sample to eedfad3f086678d282a00d8ff3cf8932d5d29af5. Keep the six existing samples at their current revision.
  • Check the complete row count in both read paths. The shared samples contain 50 rows; adjust the expected data accordingly.

Are these changes tested?

On JDK 17, macOS ARM64:

  • ./mvnw -pl parquet-hadoop verify -Dit.test=ITTestEncryptionOptions -Dmaven.javadoc.skip=true -Dsource.skip=true: 882 unit cases passed, 26 skipped; the encryption integration test passed.
  • A valid zero-row replacement for the new shared file is ignored by the original suite. The extended suite fails with expected 50 / actual 0. Restoring the real sample passes.
  • Spotless and RAT checks pass.

The zero-row control was local validation tooling and is not included in this patch.

Are there any user-facing changes?

Test coverage only.

AI-generated test changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant