Skip to content

MINOR: Require approval and deletion after merge - #3922

Merged
Fokko merged 1 commit into
masterfrom
fd-amend-config
Nov 2, 2026
Merged

Fokko merged 1 commit into
masterfrom
fd-amend-config

Conversation

@Fokko

@Fokko Fokko commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

This PR adds three things:

  • Automatic deletion of the branch after merge, to keep things tidy.
  • Require approval before merging, to avoid merging things without a review. Or committing directly to main through the UI, without going through a PR.
  • Require a linear history. I think we already do this by enforcing squash above on line 31, but good to make it explicit as well.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR adds three things:

- Automatic deletion of the branch after merge, to keep things tidy.
- Require approval before merging, to avoid merging things without a review. Or committing directly to main through the UI, without going through a PR.
- Require a linear history. I think we already do this by enforcing squash above on line 31, but good to make it explicit as well.
@Fokko
Fokko requested a review from wgtmac November 1, 2026 06:39
@Fokko
Fokko merged commit 29b3e2c into master Nov 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants