GH-3587: Test Util -1 max message size sentinel - #3800
Open
sankalpsthakur wants to merge 1 commit into
Open
sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
The validation fix is already on master; GitHub issue 3587 stayed open because apache#3588 used Closes #apacheGH-3587. Cover the -1 default at the Util read path and document the public sentinel. Co-authored-by: Sankalp Thakur <sankalpsthakur@users.noreply.github.com>
divjotarora
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#3587 reports that
parquet.thrift.string.size.limit = -1(the documented “use default”) was rejected as a non-positive value. The validation fix landed in #3588, but that PR usedCloses #GH-3587, so GitHub never linked or closed the issue.This change pins the
-1sentinel at theUtilread path (the original throw site) and documents it on the public API.What changes are included in this PR?
Util.readFileMetaData(InputStream, int)treats-1as the default 100 MB limit.-1succeeds,0and other negatives still fail.Are these changes tested?
Yes.
parquet-format-structuresTestUtil: Tests run: 5, Failures: 0parquet-hadoopTestParquetFileReaderMaxMessageSize: Tests run: 6, Failures: 0Are there any user-facing changes?
Javadoc only. No format or behavior change relative to current master.
Contributor: Sankalp Thakur (
sankalpsthakur). Apache ICLA note: this contribution is offered under the Apache License 2.0; please confirm ICLA status against ASF records if required for merge.Closes #3587