Conversation
…pache#3748) (cherry picked from commit 2431888)
wgtmac
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport #3748 to
parquet-1.19.xto fix column-index filtering returning a value from an earlier row when the final selected row requires advancing to another page.What changes are included in this PR?
Clean cherry-pick of 2431888, with no adaptations. Keep
SynchronizingColumnReaderactive until its final selected row is reached, and include the original four regression tests covering optional/repeated columns and V1/V2 pages.Are these changes tested?
Validated on
parquet-1.19.xatd29073e0dfa1dd9048b3bcee920b56e29ab1ad59using Java 17, Maven 3.9.16, and Thrift 0.24.0:./mvnw -pl parquet-column -am -Dtest=TestColumnReaderImpl -Dsurefire.failIfNoSpecifiedTests=false test: 7 tests passed, including all four backported regressions../mvnw -pl parquet-column -am spotless:check: passed.git diff --check: passed; the backport patch matches the original merged commit.Are there any user-facing changes?
Column-index filtering returns the correct value for the final selected row. No public API or file-format changes.
Original PR: #3748. Related issue: #3747.