Skip to content

GH-3710: Tolerate unrecognized logical/physical type combinations when reading #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divjotarora wants to merge 7 commits into
base: master
Choose a base branch
from
Open

GH-3710: Tolerate unrecognized logical/physical type combinations when reading #3711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c9076e2
Tolerate unrecognized logical/physical type combinations when reading
divjotarora Aug 6, 2026
1bc239c
address comments + test
divjotarora Aug 18, 2026
29a3a8b
address comments
divjotarora Aug 20, 2026
da38ee3
update parquet-testing file ref
divjotarora Sep 8, 2026
8a64bd5
address comments
divjotarora Sep 9, 2026
af6f12a
improvements
divjotarora Sep 9, 2026
907c56d
add test
divjotarora Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions parquet-arrow/src/test/java/org/apache/parquet/arrow/schema/TestSchemaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ public void testParquetInt64TimeMillisToArrow() {
.named("a"))
.named("root")))
.isInstanceOf(IllegalStateException.class)
.hasMessage("TIME(MILLIS,false) can only annotate INT32");
.hasMessage("TIME(MILLIS,false) can only annotate [INT32]");
}

@Test
Expand All @@ -581,7 +581,7 @@ public void testParquetInt32TimeMicrosToArrow() {
.named("a"))
.named("root")))
.isInstanceOf(IllegalStateException.class)
.hasMessage("TIME(MICROS,false) can only annotate INT64");
.hasMessage("TIME(MICROS,false) can only annotate [INT64]");
}

@Test
Expand Down Expand Up @@ -649,7 +649,7 @@ public void testParquetInt32TimestampMillisToArrow() {
.named("a"))
.named("root")))
.isInstanceOf(IllegalStateException.class)
.hasMessage("TIMESTAMP(MILLIS,false) can only annotate INT64");
.hasMessage("TIMESTAMP(MILLIS,false) can only annotate [INT64]");
}

@Test
Expand All @@ -660,6 +660,6 @@ public void testParquetInt32TimestampMicrosToArrow() {
.named("a"))
.named("root")))
.isInstanceOf(IllegalStateException.class)
.hasMessage("TIMESTAMP(MICROS,false) can only annotate INT64");
.hasMessage("TIMESTAMP(MICROS,false) can only annotate [INT64]");

@Fokko Fokko Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe we can drop the brackets to avoid having to update these tests

@divjotarora divjotarora Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an intentional change as there might be multiple valid physical types and I felt printing as an array helps readability

}
}
Loading