MINOR: Respect ByteBuffer offset in Binary equality - #3701
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ByteBufferBackedBinary.equals(ByteBuffer, int, int)compares from index 0 instead of the binary’s stored offset. For direct buffers with a non-zero position, this can make equal values compare unequal and can also make different values compare equal when prefix bytes happen to match.What changes are included in this PR?
Use the stored offset when comparing a
ByteBufferBackedBinarywith anotherByteBuffer. Add regression coverage for equality symmetry, matching hash codes, and unequal values whose prefix bytes match.Are these changes tested?
Yes.
TestBinarypasses with 16 tests, and the Spotless check passes.Are there any user-facing changes?
Equality for direct
ByteBuffer-backed binaries now uses the bytes represented by the binary slice.