Skip to content

GH-3449: Fix BinaryStats int overflow #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jiayi-Wang-db wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −3
Open

GH-3449: Fix BinaryStats int overflow #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a925781
Fix int overflow
Mar 16, 2026
9d92fd6
Avoid 1 GB allocation in overflow test
Jiayi-Wang-db Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions parquet-column/src/main/java/org/apache/parquet/column/statistics/BinaryStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,16 @@ String stringify(Binary value) {

@Override
public boolean isSmallerThan(long size) {
return !hasNonNullValue() || ((min.length() + max.length()) < size);
return !hasNonNullValue() || (((long) min.length() + max.length()) < size);
}

public boolean isSmallerThanWithTruncation(long size, int truncationLength) {
if (!hasNonNullValue()) {
return true;
}

int minTruncateLength = Math.min(min.length(), truncationLength);
int maxTruncateLength = Math.min(max.length(), truncationLength);
long minTruncateLength = Math.min(min.length(), truncationLength);
long maxTruncateLength = Math.min(max.length(), truncationLength);

return minTruncateLength + maxTruncateLength < size;
}
Expand Down
11 changes: 11 additions & 0 deletions parquet-column/src/test/java/org/apache/parquet/column/statistics/TestStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,4 +927,15 @@ public void testNoopStatistics() {
assertThrows(UnsupportedOperationException.class, stats::minAsString);
assertThrows(UnsupportedOperationException.class, () -> stats.isSmallerThan(0));
}

@Test
public void testBinaryIsSmallerThanNoOverflowForLargeValues() {
BinaryStatistics stats = new BinaryStatistics();
// Create a Binary whose length() reports 2^30 without allocating 1 GB
Binary fakeLarge = Binary.fromConstantByteArray(new byte[0], 0, 1 << 30);
stats.updateStats(fakeLarge);

// min.length() + max.length() = 2^31, must not overflow int to negative
assertFalse(stats.isSmallerThan(4096));
}
}