GH-3307: Replace deprecated BIT_PACKED with RLE in DevNullValuesWriter#3446
Open
LuciferYang wants to merge 1 commit intoapache:masterfrom
Open
GH-3307: Replace deprecated BIT_PACKED with RLE in DevNullValuesWriter#3446LuciferYang wants to merge 1 commit intoapache:masterfrom
LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #3307
When repetition/definition levels are empty (i.e.,
maxLevel == 0for required, non-repeated fields),DevNullValuesWriteris used as a no-op writer that produces zero bytes. However, itsgetEncoding()method returns the deprecatedBIT_PACKEDencoding, which gets written into theDataPageHeadermetadata (repetition_level_encoding/definition_level_encoding) and the column chunk encoding list.Since parquet-java already uses
RLEas the encoding for levels, the metadata should reflectRLErather than the deprecatedBIT_PACKED.What changes are included in this PR?
Changed
DevNullValuesWriter.getEncoding()to returnEncoding.RLEinstead ofEncoding.BIT_PACKED.Are these changes tested?
Yes. All existing tests in
parquet-columnandparquet-hadooppass without modification.Are there any user-facing changes?
Newly written Parquet files will report
RLEinstead ofBIT_PACKEDin page header metadata for empty repetition/definition levels. This has no impact on file compatibility — readers do not decode level data when the byte length is zero, regardless of the encoding value in the header.