Minor: ci-before_install.sh should show wget errors and retry
#3381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dossett
commented
Dec 29, 2025
| sudo apt-get update -qq | ||
| sudo apt-get install -qq --no-install-recommends build-essential pv autoconf automake libtool curl make \ | ||
| g++ unzip libboost-dev libboost-test-dev libboost-program-options-dev \ | ||
| g++ unzip libboost-dev libboost-test-dev libboost-program-options-dev wget \ |
Contributor
Author
There was a problem hiding this comment.
Trying to ensure an up to date version of wget
Contributor
Author
|
I actually saw some failures on the workflows kicked off from this PR: I pushed an additional change to try the wget command up to three times. Hopefully this makes the actions less flaky. |
dossett
changed the title
Fokko
changed the title
ci-before_install.sh should show wget errors and retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wgetfetch of the thrift distribution is failing sometimes (due to rate limiting?) but the exact failure is completely suppressed with the-qflag. Adding-nvwill show the errors but keep the successes quiet. Setting pipefail will allow the script to fail fast at this point since the failure is in a pipelined command.If we see that rate limiting is in fact the problem, we can add retries here.