[core] Enable bundle writes in append-only compaction - #9680
Closed
jianguotian wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Append-only compaction currently consumes every reader batch row by row, even when a format reader can expose the complete logical batch as
BundleRecords.This PR adds a format-neutral Core bridge for bundle-capable compaction readers:
BundleRecordIteratorto expose all unconsumed logical rows as a borrowed bundle.BaseAppendFileStoreWrite.compactRewritewrite such bundles directly, while always releasing each batch and closing the reader on success or failure.This PR intentionally provides only the Core bridge. Format-specific bundle producers and direct writers can be added in follow-up PRs.
This complements #9660, which adds a Parquet row-group copy fast path. Both touch
BaseAppendFileStoreWrite, so the PR merged second may need a small rebase.Tests
ColumnarRowIteratorTestandBaseAppendFileStoreWriteTest(8 tests passed).ColumnarRowIteratorTestandBaseAppendFileStoreWriteTest(8 tests passed).