[flink] Honor snapshot limit in exactly-once monitor source - #9677
Open
jianguotian wants to merge 1 commit into
Open
[flink] Honor snapshot limit in exactly-once monitor source#9677jianguotian wants to merge 1 commit into
jianguotian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FlinkSourceBuilderselectsMonitorSourcefor streaming reads with aconsumer-idinEXACTLY_ONCEmode. This path did not honorscan.max-snapshot.count, so it could continue planning non-empty snapshots before checkpoint completion confirmed progress for the snapshots already in flight.This PR makes the monitor source enforce the configured snapshot limit and ties snapshot-credit release to completed checkpoints.
Changes
scan.max-snapshot.countfrom the table options in theMonitorSourcebuild pathThe limit applies to concurrently planned snapshots. It does not cap the records or splits within one snapshot and does not change
scan.max-splits-per-tasksemantics.Tests
OperatorSourceTestwith Flink 1.x: 10 tests passedOperatorSourceTestwith Flink 2.x: 10 tests passedgit diff --check