[api] Fall back to the HTTP status when the error body omits code - #9661
Open
jackylee-ch wants to merge 1 commit into
Open
[api] Fall back to the HTTP status when the error body omits code#9661jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
jackylee-ch
force-pushed
the
rest-error-code-nullable
branch
from
September 7, 2026 01:52
18d36bf to
e0dc764
Compare
The creator parameter for "code" was primitive, so Jackson filled 0 for an absent value and getCode() was never null. That made the HTTP-status fallback in HttpClient unreachable and turned a 404 without a body code into a generic RESTException reading "(HTTP 0)".
jackylee-ch
force-pushed
the
rest-error-code-nullable
branch
from
September 7, 2026 11:14
e0dc764 to
24a1767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ErrorResponse's field and getter areInteger, but the@JsonCreatorparameter was primitiveintand the shared mapper leavesFAIL_ON_NULL_FOR_PRIMITIVESoff.codehas norequired:entry inrest-catalog-open-api.yaml, so a server may legally omit it; it then deserialized to0, the HTTP-status fallback inHttpClient#buildErrorResponsenever fired, and a 404 surfaced asRESTExceptionreading(HTTP 0)instead ofNoSuchResourceException.DefaultErrorHandlertolerates a null code too.Public constructor signature change in
paimon-api: source- but not binary-compatible.Tests
HttpClientTest.Written with Claude Code; reasoning and verification are mine.