-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[python] Support BlobView feature #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
discivigour
wants to merge
34
commits into
apache:master
Choose a base branch
from
discivigour:p/blobView1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,298
−157
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
732c0bf
[python] Support blob view fields
leaves12138 e75d6c1
[python] Refine blob view lookup
leaves12138 45cb386
[python] Stabilize concurrent update test
leaves12138 0fecd79
proto
975ec42
simplify
528ad93
prescan
60ce34b
fix
a441a33
fix
19c8a53
refine
96eed81
fmt
f8326b9
fix
6feb435
rm
ac8499f
fix
7aa3836
fmt
8ef2ff0
fix
8fb7548
fix
17ae8ce
fix
967a0c6
support blob-view.resolve.enabled and null blob value
1035cb1
remove redundant code
9fe7eb0
fix
80af025
from bytes supports BlobView
77e1a62
fix
a594ad3
rebase
b0bae12
fix
ea2509b
fix
179a0bc
fix
819950b
schema
fac4e15
fix
48c13ff
schemaCheck
2ddb95f
fix
41f849f
supportLimit
0383e5a
fmt
c36806b
fix
e2b20c6
fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] This prescan exhausts the prescan reader before the first main batch is returned. In Python,
limitis enforced by outerTableReadafter a batch is returned or sliced, andDataEvolutionSplitReaditself never receives that limit. Java wirestopN/limitinto the prescan reader inDataEvolutionTableRead.configureBlobViewPrescanRead. As a result, Pythonwith_limit(1)can still prescan and validate every laterBlobViewStructin the same split, and can even fail on a bad reference that the user-visible result would never return. Please pass limit/topN into the prescan scope, or at least add a blob-view + limit test to lock down the intended behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pypaimon, currently, the limit pushdown in the Read stage of the Append table is not supported. I will support this function in the next pr