Skip to content

[cdc] fix special regex characters unescaped in excluded table patterns #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ziyanTOP wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

[cdc] fix special regex characters unescaped in excluded table patterns #7619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...imon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import static org.apache.paimon.flink.action.MultiTablesSinkMode.COMBINED;
Expand Down Expand Up @@ -302,19 +303,19 @@ public static String combinedModeTableList(
// be excluded by excluding pattern at the same time
String includingPattern =
String.format("(%s)\\.(%s)", databasePattern, includingTablePattern);

LOG.info("Combined mode including pattern is {}", includingPattern);
if (excludedTables.isEmpty()) {
return includingPattern;
}

// Use Pattern.quote to escape special regex characters (e.g., '$' in mysql table name)
// in database and table names, ensuring exact literal matching in the regex.
String excludingPattern =
excludedTables.stream()
.map(
t ->
String.format(
"(^%s$)",
t.getDatabaseName() + "\\." + t.getObjectName()))
.map(Identifier::getFullName)
.map(n -> String.format("(^%s$)", Pattern.quote(n)))
.collect(Collectors.joining("|"));
LOG.info("Combined mode excluding pattern is {}", excludingPattern);
excludingPattern = "?!" + excludingPattern;
return String.format("(%s)(%s)", excludingPattern, includingPattern);
}
Expand Down