Repository navigation
Conversation
taoran92
marked this pull request as ready for review
October 30, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #10892.
RemoveOrphanBlobsProcedureTestcan fail before its deletion assertions when a shuffle is unregistered between enumerating its ID and invalidating its outputs. Skip only the missing-shuffle error for the current ID and continue invalidating the remaining shuffles; propagate unrelated errors.Retain shuffle output invalidation so the existing cache-eviction tests still exercise recomputation.
Tests
Added deterministic coverage for unregistering a captured shuffle ID, clearing the remaining registered shuffle, and propagating unrelated errors. The race regression fails without the missing-shuffle guard on Spark 3.5.8 and Spark 4.1.2.
ShuffleOutputCleanupTest(8 tests) andRemoveOrphanBlobsProcedureTest(21 tests) passed on all three combinations: