Repository navigation
[format][python] Support large video indexes with paged reads - #10891
Draft
XiaoHongbo-Hope wants to merge 2 commits into
Draft
XiaoHongbo-Hope wants to merge 2 commits into
XiaoHongbo-Hope wants to merge 2 commits into
Conversation
XiaoHongbo-Hope
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Long videos currently lose their generated seek index when they exceed the keyframe limit. Remove that limit and the 16 MiB per-index / 64 MiB per-file limits without loading entire indexes into memory.
.videolayout is unchanged; v2 indexes require updated readers. Pages use uncompressed int64 triples, trading index size for direct reads. The metadata-range limit is unchanged.Tests
Python: 74 passed, 19 native-runtime cases skipped. Java: 21 descriptor/format tests and 2 rolling/compaction tests passed.
Covers one million keyframes, indexes above 16 MiB and 64 MiB per file, lazy reads, corruption, failure cleanup, shared Java/Python fixtures, and real indexed video/training reads. Python 3.6 syntax, flake8 and diff checks passed.