Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Close the local input stream owned by
FileBasedBloomFilterTest.testProbe.FileBasedBloomFilter.close()invalidates its cached page but leaves the shared input open, so JUnit cannot delete the temporary file on Windows.Manage the test input and cache manager with try-with-resources. Keep the existing
filter.close()call and cache assertions inside that scope so manager cleanup cannot hide an invalidation failure. This changes one test file and adds no production behavior.Tests
Ran the complete
FileBasedBloomFilterTeston Windows / JDK 8u451 and Linux / JDK 8u441:mvn -o -B -ntp -pl paimon-common -am -DwildcardSuites=none -DfailIfNoTests=false -Dtest=FileBasedBloomFilterTest testBoth final runs passed without
fast-build. Linux also validates Checkstyle outside atarget-suppressed source path. Full-project tests and official PR CI have not run.