Repository navigation
Conversation
apache#5505 raised scala212.version (and thus codegen.scala.version) from 2.12.15 to 2.12.18, but the bundled META-INF/NOTICE of paimon-codegen still lists scala-compiler, scala-library and scala-reflect 2.12.15. Update the three version tokens to match the shaded jars. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10869
scala212.version(whichcodegen.scala.versionresolves to) from 2.12.15 to 2.12.18 without updating the module's bundledMETA-INF/NOTICE, so releasedpaimon-codegenjars (e.g. 2.1.0) declare Scala 2.12.15 while theirlibrary.properties,compiler.propertiesandreflect.propertiesreport 2.12.18.scala-compiler,scala-libraryandscala-reflectto 2.12.18 — no other lines touched.Tests
mvn -pl paimon-codegen -DskipTests package(JDK 11) prints:META-INF/NOTICEnow lists 2.12.18, matchingmaven.version.number=2.12.18in its three*.propertiesfiles.mvn spotless:check -pl paimon-codegen: BUILD SUCCESS.