Repository navigation
[core] Add delete-row.thin-mode for primary-key tables - #10863
Open
discivigour wants to merge 6 commits into
Open
discivigour wants to merge 6 commits into
discivigour wants to merge 6 commits into
Conversation
added 5 commits
October 29, 2026 17:01
discivigour
force-pushed
the
j/delete-row-fields-projection
branch
from
October 29, 2026 09:04
c3d63e1 to
81828c9
Compare
discivigour
marked this pull request as ready for review
October 29, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Whole-record DELETE rows currently store nullable payload values that are unnecessary for applying the deletion. Add
delete-row.thin-mode(default:false) to write these fields as null in primary-key data files, including clustering files.Preserve primary-key, sequence, record-level time, clustering, and non-null fields, along with the record's RowKind and sequence number. The physical schema is unchanged, and this option is independent of
data-file.thin-mode. Changelog files retain their original payloads.Schema validation requires a primary-key table using deduplicate, or partial-update/aggregation with whole-record deletion enabled, and rejects postpone bucket tables (
bucket = -2). The option is disabled by default because audit-log and delta readers that expose data-file DELETE rows can observe the cleared fields; disabling it later cannot restore values already written as null.Tests
35 targeted tests passed on
c3d63e14a3, with Checkstyle and Spotless enabled:DeleteRowFieldsProjectorTestandDeleteRowFieldsTest: default-off behavior, required fields, filtering, compaction, reinsertion, and create/alter/dynamic-option validation.SchemaValidationTest#testDeleteRowThinMode*: supported and unsupported table configurations.KeyValueFileReadWriteTest#testDeleteRowFieldsProjection+testDeleteRowFieldsProjectionInClusteringFile: Avro/ORC/Parquet, both data-file thin-mode settings, clustering fields, and unchanged changelog payloads.PrimaryKeySortedIndexReadTestandPrimaryKeyBlobFileWriterTest: indexed reads with deletion vectors and blob writer regressions.