perf(manifest): write bucket-first sorted entries - #852
Open
jianguotian wants to merge 1 commit into
Open
jianguotian wants to merge 1 commit into
jianguotian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Keep entries for fixed-bucket and postponed-bucket tables close by bucket when
Rust writes a manifest. This produces tighter
_MIN_BUCKET/_MAX_BUCKETenvelopes after rolling, so scans can skip more manifest files before fetching
and decoding their contents.
This is the write-side counterpart to the bucket metadata pruning added in
#850 and follows the bucket-first layout introduced by Apache Paimon Java in
apache/paimon#9792 and extended to non-partitioned fixed/postponed-bucket tables
in apache/paimon#9808.
Changes
manifest-sort.enabledtable option (defaultfalse)the existing Rust minor/full merge paths
The implementation intentionally does not claim parity with Java's explicit
compact_manifestaction (apache/paimon#9802): paimon-rust does not currentlyhave the corresponding action/procedure API. Existing one-file manifest lists
are therefore not force-rewritten solely by this option; adding that API can be
reviewed independently.
Tests
cargo test -p paimon --lib(2818 passed, 2 ignored)cargo clippy -p paimon --lib --tests -- -D warningscargo fmt --check