fix(spec): decode _GLOBAL_INDEX fields by name, not by position - #843
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode_nullable_global_indexread five of the six_GLOBAL_INDEXfieldspositionally, guarding only
_SOURCE_METAby name. #831 gave the siblingdeletion-vector record in the same function a name-based walk over the writer
schema and left this one behind.
Nothing in a manifest says how many fields the record has. Java tried a runtime
field-count check when
_SOURCE_METAarrived (#8549), replaced it with aserializer version (#8952), reverted that (#9004) and deleted the versioned
serializer (#9039) — shape compatibility is delegated to schema resolution, which
positional decoding cannot do.
Latent, not live:
_GLOBAL_INDEXis the last field, so an unconsumed seventhwould corrupt the next record in the block, and single-entry manifests decode
fine today. The arms also now honour each field's declared nullability instead of
assuming it.