Conversation
Wait for background writes to finish before renaming cache blocks, and clean up temporary files on write or flush errors. Verify that published blocks are immediately readable before testing cache restart recovery. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #835.
Tokio background writes could finish after a cache block was published, causing empty reads and intermittent persistence test failures.
Brief change log
Tests
cargo fmt --all -- --checkcargo test --locked -p paimon --all-targets --features fulltext,vortexcargo clippy --locked --all-targets --workspace --features fulltext,vortex -- -D warningsAPI and Format
No changes.
Documentation
Not needed.