fix(rest-server): use Java's uppercase resourceType in error responses - #830
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five
resourceTypevalues this server emits are lowercase, but Java'sErrorResponsedeclares them asDATABASE/TABLE, and a Java clientdispatches on the field:
RESTCatalog#alterTableraisesTableNotExistExceptiononly when it equalsRESOURCE_TYPE_TABLE, comparingchar by char through
StringUtils#equals. Withtableneither branch matches,so
alterTable(ident, changes, false)on a missing table silently returnsinstead of throwing.
createBranchrethrows in the same position, so thesymptom varies by call.
They are now the uppercase constants. No effect on the Rust client, which keys
off the status code alone.
Left alone deliberately: the two column errors still answer 400 with
column:<table>. Making them Java's 404 plusCOLUMNneeds the Rust clientchanged too, which would otherwise read a missing column as a missing table.