fix(table): support all Java-comparable types in min/max aggregators - #827
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java's
FieldMinAggFactoryandFieldMaxAggFactoryaccept any typeTypeCheckUtils#isComparableallows, which excludes only MAP, MULTISET, ROW,ARRAY, VECTOR, VARIANT and BLOB.
MinMaxStatecovered eleven roots and omittedfour that
InternalRowUtils#comparehandles: BOOLEAN (Boolean.compare),TIMESTAMP WITH LOCAL TIME ZONE (same branch as TIMESTAMP), BINARY and VARBINARY
(
byteArrayCompare). Configuringmaxon such a column made an aggregationtable unreadable with
Aggregate function 'max' does not support data type ....The four are added. BLOB stays rejected even though Arrow maps it to the same
Binary, and the accumulator now carries the Arrow timezone, read back frompaimon_type_to_arrowso it cannot drift — a result array without it failsRecordBatch::try_newagainst the field.An outdated comment claimed BOOLEAN has no ordering; that test now pins BLOB.