fix(fm_index): store blocks in Java's codec envelope, not the SST one - #826
Open
jackylee-ch wants to merge 2 commits into
Open
jackylee-ch wants to merge 2 commits into
jackylee-ch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_blocksent FM blocks throughcompress_block, which prepends anuncompressed-size varint. The varint belongs to the SST and bitmap block
formats, not the codec: Java's
FMIndexFile#writeBlockstoresBlockCompressoroutput verbatim withstoredLength = compressedLength, anddecodeStoredBlockdecompresses it directly. So paimon-rust cannot read aJava-written FM global index, failing with
Compressed block size does not match its metadata, and Java cannot read ours. Both default tolz4, and ZSTD isaffected too since the varint precedes the codec branch.
Fix: add a codec-only pair,
compress_codec_blockanddecompress_codec_block, and point FM at it.compress_blockkeeps the varintfor SST and bitmap, where Java does prepend it.
The V1 goldens store blocks uncompressed, so no test covered this; the new one
asserts the stored bytes against Java's envelope.