feat: support batch incremental diff reads#510
Conversation
|
There are multiple correctness issues:
|
85c0a2b to
7b47806
Compare
|
Thanks, I addressed these in 7b47806 and rebased onto latest main. Diff now compares the full schema before projection (including NULLs), rejects unsupported types, and no longer uses BinaryRow bytes for range pruning. NaN follows Java Float.compare. I also added the NULL/projection regressions. Could you take another look? |
JingsongLi
left a comment
There was a problem hiding this comment.
Can you add API doc in docs?
7b47806 to
4837703
Compare
|
Added the API guide in |
|
|
Purpose
Linked issue: close #505
Depends on: #508 and #509 (stacked). Against
mainyou'll see the whole stack; the new work is Diff planning + before/after comparison.For tables with
changelog-producer=none, Diff is how you still get an audit-style change stream without materializing changelog during write.Brief change log
DiffPairper(partition, bucket)Unsupported, no silent wrong results)+I/-U/+U/-D, skip equal rowsdiff.parallelismoption (default 4) for pair executionI used input-delete rows for delete cases in tests so we don't need compact/lookup generation in this PR.
Tests
API and Format
Documentation
Still holding docs for the DataFusion PR so users see one end-to-end story.
Known gaps (intentionally)