Skip to content

fix(datafusion): preserve string literals when rewriting MERGE references - #1266

Open
slfan1989 wants to merge 1 commit into
apache:mainfrom
slfan1989:paimon-rust-1265
Open

fix(datafusion): preserve string literals when rewriting MERGE references#1266
slfan1989 wants to merge 1 commit into
apache:mainfrom
slfan1989:paimon-rust-1265

Conversation

@slfan1989

@slfan1989 slfan1989 commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: close #1265

Fix MERGE rewriting table names inside string literals, causing incorrect stored values or predicate results.

Brief change log

  • Rewrite table qualifiers through the SQL AST instead of text replacement.
  • Preserve string literals and column names.
  • Add regression tests for ON/WHEN predicates and UPDATE/INSERT values.

Tests

  • Confirmed both new regression tests fail before the fix.

API and Format

No.

Documentation

No.

QuakeWang
QuakeWang approved these changes Nov 1, 2026
View reviewed changes

@QuakeWang QuakeWang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuakeWang QuakeWang QuakeWang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] MERGE incorrectly rewrites table names inside string literals

2 participants

@slfan1989 @QuakeWang