Repository navigation
feat(predicate): add full-text match and score projection semantics - #451
Merged
Merged
Conversation
lszskye
force-pushed
the
file_index_predicate_tree
branch
from
October 21, 2026 09:27
29e364d to
7491b9a
Compare
lxy-9602
reviewed
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #452
Existing search setters cannot represent full-text conditions inside mixed
AND/OR filters, such as
body matches "apple" OR price < 10.This PR introduces the predicate semantics and interfaces for these queries:
FullTextMatchas a leaf in the existing predicate tree, using thesame JSON DSL as
FullTextSearchwithout TopK truncation.schema renaming without modifying the original shared request.
search inputs.
_<field>_INDEX_SCOREprojections and bind each outputposition to a search type and original table field name.
conditions beneath OR. Root TopK requires internal scores regardless
of projection.
This PR covers construction, validation, and binding. Full-text predicate
execution, scan pruning with full-text predicates, and per-field score
materialization return
NotImplemented. Mixed-query execution, cross-fileTopK merging, and selectivity-based scheduling will follow separately.
Tests
Added coverage for:
scalar/statistics evaluation.
LeafPredicate.API and Format
Adds:
FullTextMatchPredicateBuilder::FullTextMatchPredicateUtils::ContainsFullTextMatchFunction::Type::FULL_TEXT_MATCHFileIndexReader::VisitFullTextMatchDocumentation
Document predicate composition, root TopK semantics, score projection rules,
and current execution limitations in
docs/source/api/file_index.rst.Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)